Messages in this thread | | | Date | Fri, 26 Nov 2010 10:39:23 +1100 | Subject | Re: [PATCH 1/1] NET: wan/x25_asy, move lapb_unregister to x25_asy_close_tty | From | Andrew Hendry <> |
| |
Looks like some more X.25 users. Not sure on your usage, but I should point out: https://patchwork.kernel.org/patch/332981/ X.25 protocol needs to have the big kernel lock removed so it can stay around in the future. I have been working through them, but there are still some of the more complex ones remaining.
The test setups I am using are: Sockets<->X25<->x25loop<->X25<->Sockets Sockets<->X25<->xotd<->network<->xotd<->X25<->Sockets and I know some users have: Sockets<->X25<->xotd<->network<->CiscoXOT<->devices.
Where x25loop is a userspace tun device which shuffles the LCIs, does some basic call handling and loops the calls back into kernel X25. xotd is a basic implementation of the X25 over TCP RFC.
Are you using something like this? Sockets<->X25<->lapb<->x25_async<->.....
If you are using X25 I would be interested to see how your setup goes with the X25 BKL cleanup work, and if anyone wanted to help with the remaining BKLs :)
On Fri, Nov 26, 2010 at 9:56 AM, Sergey Lapin <slapin@ossfans.org> wrote: > On Thu, Nov 25, 2010 at 12:54:54AM +0100, Jiri Slaby wrote: >> We register lapb when tty is created, but unregister it only when the >> device is UP. So move the lapb_unregister to x25_asy_close_tty after >> the device is down. >> >> Signed-off-by: Jiri Slaby <jslaby@suse.cz> >> Reported-by: Sergey Lapin <slapin@ossfans.org> >> Cc: Andrew Hendry <andrew.hendry@gmail.com> > Tested-by: Sergey Lapin <slapin@ossfans.org> > Tested-by: Mikhail Ulyanov <ulyanov.mikhail@gmail.com> >
| |