lkml.org 
[lkml]   [2010]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [patch 4/4] taskstats: Export "cdata_acct" with taskstats
    From
    Date
    Hello Oleg,

    On Thu, 2010-11-25 at 14:26 +0100, Oleg Nesterov wrote:
    > On 11/19, Michael Holzheu wrote:
    > >
    > > From: Michael Holzheu <holzheu@linux.vnet.ibm.com>
    > >
    > > With this patch the (full) cumulative CPU time is added to "struct taskstats".
    > > The CPU time is only returned for the thread group leader.
    > >
    > > ...
    > >
    > > + if (tsk->tgid == tsk->pid
    >
    > thread_group_leader() ?

    Yes, that's better.

    > > && lock_task_sighand(tsk, &flags)) {
    >
    > Do you really need ->siglock? Starting from 2.6.35 it is always
    > safe to access ->signal.

    Hmmm, if you say that...

    I just did it like it is done in e.g. fs/proc/base.c (proc_pid_limits).
    Can we remove the locking there, too?

    Michael



    \
     
     \ /
      Last update: 2010-11-25 18:23    [W:4.737 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site