Messages in this thread | | | Subject | Re: [patch 4/4] taskstats: Export "cdata_acct" with taskstats | From | Michael Holzheu <> | Date | Thu, 25 Nov 2010 18:21:15 +0100 |
| |
Hello Oleg,
On Thu, 2010-11-25 at 14:26 +0100, Oleg Nesterov wrote: > On 11/19, Michael Holzheu wrote: > > > > From: Michael Holzheu <holzheu@linux.vnet.ibm.com> > > > > With this patch the (full) cumulative CPU time is added to "struct taskstats". > > The CPU time is only returned for the thread group leader. > > > > ... > > > > + if (tsk->tgid == tsk->pid > > thread_group_leader() ?
Yes, that's better.
> > && lock_task_sighand(tsk, &flags)) { > > Do you really need ->siglock? Starting from 2.6.35 it is always > safe to access ->signal.
Hmmm, if you say that...
I just did it like it is done in e.g. fs/proc/base.c (proc_pid_limits). Can we remove the locking there, too?
Michael
| |