Messages in this thread | | | Date | Thu, 25 Nov 2010 14:49:40 -0200 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [RFC PATCHv3] perf tools: add event grouping capability to "perf stat" |
| |
Em Thu, Nov 25, 2010 at 03:18:58PM +0100, Stephane Eranian escreveu: > On Thu, Nov 25, 2010 at 3:12 PM, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote: > > perf-record already does that: > > > > if (nr_counters > 1) > > attr->sample_type |= PERF_SAMPLE_ID; > > > Ok, that's good. > The other thing I saw, is that perf report assumes that sample_type is the > same for all events, otherwise it dies.
Right, we need to have object attributes, and then pass them to perf_session__new, so that it creates the counters, etc, instead of having top, record, etc doing it in ad hoc ways.
I'll try to attack this soon, after tinishing the sample_type_id_all, that in the kernel is per attribute, but in the tooling side suffers from the one sample_type per session, not per attribute problem too.
- Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |