lkml.org 
[lkml]   [2010]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86, dumpstack: Fix unused variable warning.
Le Thu, 25 Nov 2010 11:35:16 +0600,
Rakib Mullick <rakib.mullick@gmail.com> a écrit :

> On Wed, Nov 24, 2010 at 7:19 PM, Frederic Weisbecker
> <fweisbec@gmail.com> wrote:
> > 2010/11/24 Rakib Mullick <rakib.mullick@gmail.com>:
> >
> > Looks like you can even remove that block. bp is not used any more
> > in this function.
> > get_bp() was only loading bp but did not make any use of it.
>
> Yes, right. Here is the updated one.
>
> In dump_stack function, bp isn't used anymore, which is introduced by
> commit 9c0729dc8062bed96189bd14ac6d4920f3958743. This patch removes bp
> completely.
>
>
> Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com>
> ---
>
> diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
> index 8474c99..d6fb146 100644
> --- a/arch/x86/kernel/dumpstack.c
> +++ b/arch/x86/kernel/dumpstack.c
> @@ -197,14 +197,8 @@ void show_stack(struct task_struct *task,
> unsigned long *sp)
> */
> void dump_stack(void)
> {
> - unsigned long bp = 0;
> unsigned long stack;
>
> -#ifdef CONFIG_FRAME_POINTER
> - if (!bp)
> - get_bp(bp);
> -#endif
> -
> printk("Pid: %d, comm: %.20s %s %s %.*s\n",
> current->pid, current->comm, print_tainted(),
> init_utsname()->release,
>

Queued, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-11-25 07:35    [W:0.037 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site