Messages in this thread | | | Date | Thu, 25 Nov 2010 22:54:57 +1100 | From | Nick Piggin <> | Subject | Re: [RFC][PATCH] Possible data integrity problems in lots of filesystems? |
| |
On Thu, Nov 25, 2010 at 06:49:09PM +1100, Nick Piggin wrote: > Second is confusing sync and async inode metadata writeout > Core code clears I_DIRTY_SYNC and I_DIRTY_DATASYNC before calling > ->write_inode *regardless* of whether it is a for-integrity call or > not. This means background writeback can clear it, and subsequent > sync_inode_metadata or sync(2) call will skip the next ->write_inode > completely.
Hmm, this also means that write_inode_now(sync=1) is buggy. It needs to in fact call ->fsync -- which is a file operation unfortunately, Christoph didn't you have some patches to move it into an inode operation?
| |