Messages in this thread | | | Date | Thu, 25 Nov 2010 13:48:17 +0300 | From | Anton Vorontsov <> | Subject | Re: [PATCH v2 2/3] ARM: cns3xxx: Add architecture definition for EHCI/OHCI controller |
| |
On Thu, Nov 25, 2010 at 03:25:38PM +0800, Lin Mac wrote: [...] > > #include <linux/module.h> > > #include <linux/io.h> > > #include <linux/delay.h> > > +#include <asm/atomic.h> > It's not necessary for mach/pm.h already included it, right?
Technically, it's not necessary. But in Linux we don't rely on headers including other headers. Think that someday mach/pm.h may not include asm/atomic.h, so the build will break.
Thanks,
> > > #include <mach/system.h> > > #include <mach/cns3xxx.h> > > #include <mach/pm.h> > > @@ -117,3 +118,6 @@ int cns3xxx_cpu_clock(void) > > return cpu; > > } > > EXPORT_SYMBOL(cns3xxx_cpu_clock); > > + > > +atomic_t usb_pwr_ref = ATOMIC_INIT(0); > > +EXPORT_SYMBOL(usb_pwr_ref);
-- Anton Vorontsov Email: cbouatmailru@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |