lkml.org 
[lkml]   [2010]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: make ioremap_prot() take a pgprot.
On Tue, Nov 09, 2010 at 01:18:19AM +1100, Benjamin Herrenschmidt wrote:
> On Mon, 2010-11-08 at 15:34 +0900, Paul Mundt wrote:
> > On Wed, Nov 03, 2010 at 05:31:03AM +0900, Paul Mundt wrote:
> > > The current definition of ioremap_prot() takes an unsigned long for the
> > > page flags and then converts to/from a pgprot as necessary. This is
> > > unfortunately not sufficient for the SH-X2 TLB case which has a 64-bit
> > > pgprot and a 32-bit unsigned long.
> > >
> > > An inspection of the tree shows that tile and cris also have their
> > > own equivalent routines that are using the pgprot_t but do not set
> > > HAVE_IOREMAP_PROT, both of which could trivially be adapted.
> > >
> > > After cris/tile are updated there would also be enough critical mass to
> > > move the powerpc devm_ioremap_prot() in to the generic lib/devres.c.
> > >
> > > Signed-off-by: Paul Mundt <lethal@linux-sh.org>
> > >
> > Any takers?
>
> Haven't had a chance to play with it yet, still travelling.
>
Ping.


\
 
 \ /
  Last update: 2010-11-24 09:51    [W:0.054 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site