lkml.org 
[lkml]   [2010]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 09/16 v4] pramfs: dir operations
On Sat, Nov 20, 2010 at 11:00:45AM +0100, Marco Stornelli wrote:
> +int pram_add_link(struct dentry *dentry, struct inode *inode)
> +{
> + struct inode *dir = dentry->d_parent->d_inode;
> + struct pram_inode *pidir, *pi, *pitail = NULL;
> + u64 tail_ino, prev_ino;
> +
> + const char *name = dentry->d_name.name;
> +
> + int namelen = dentry->d_name.len > PRAM_NAME_LEN ?
> + PRAM_NAME_LEN : dentry->d_name.len;
> +

namelen = min_t(unsigned int, dentry->d_name.len, PRAM_NAME_LEN);

?

> +#define S_SHIFT 12
> +static unsigned int dtype_by_mode[S_IFMT >> S_SHIFT] = {
> + [S_IFREG >> S_SHIFT] DT_REG,
> + [S_IFDIR >> S_SHIFT] DT_DIR,
> + [S_IFCHR >> S_SHIFT] DT_CHR,
> + [S_IFBLK >> S_SHIFT] DT_BLK,
> + [S_IFIFO >> S_SHIFT] DT_FIFO,
> + [S_IFSOCK >> S_SHIFT] DT_SOCK,
> + [S_IFLNK >> S_SHIFT] DT_LNK,
> +};
> +
> +static int pram_readdir(struct file *filp, void *dirent, filldir_t filldir)
> +{
...
> + ret = filldir(dirent, name, namelen,
> + filp->f_pos, ino,
> + dtype_by_mode[(be16_to_cpu(pi->i_mode) & S_IFMT)>>S_SHIFT]);
> + filp->f_pos = pi->i_d.d_next ? be64_to_cpu(pi->i_d.d_next) : 3;

You might try to provide some generic helpers for this, at least GFS2
also does the same thing:

include/linux/gfs2_ondisk.h:#define DT2IF(dt) (((dt) << 12) & S_IFMT)
include/linux/gfs2_ondisk.h:#define IF2DT(sif) (((sif) & S_IFMT) >> 12)


\
 
 \ /
  Last update: 2010-11-24 09:21    [W:0.038 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site