Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 24 Nov 2010 20:33:36 -0500 | From | Dave Jones <> | Subject | Re: rcu_read_lock/unlock protect find_task_by_vpid call in migrate_pages |
| |
On Thu, Nov 25, 2010 at 09:50:37AM +0900, KOSAKI Motohiro wrote:
> > @@ -1315,6 +1316,7 @@ SYSCALL_DEFINE4(migrate_pages, pid_t, pid, unsigned long, maxnode, > > goto out; > > } > > mm = get_task_mm(task); > > + rcu_read_unlock(); > > read_unlock(&tasklist_lock); > > > > err = -EINVAL; > > Thanks reporting. but mmotm seems already has the same patch.
indeed. It's also better than mine, which missed the unlock on error path.
thanks,
Dave
| ![\](/images/icornerr.gif) |