lkml.org 
[lkml]   [2010]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: rcu_read_lock/unlock protect find_task_by_vpid call in migrate_pages
On Thu, Nov 25, 2010 at 09:50:37AM +0900, KOSAKI Motohiro wrote:

> > @@ -1315,6 +1316,7 @@ SYSCALL_DEFINE4(migrate_pages, pid_t, pid, unsigned long, maxnode,
> > goto out;
> > }
> > mm = get_task_mm(task);
> > + rcu_read_unlock();
> > read_unlock(&tasklist_lock);
> >
> > err = -EINVAL;
>
> Thanks reporting. but mmotm seems already has the same patch.

indeed. It's also better than mine, which missed the unlock on error path.

thanks,

Dave



\
 
 \ /
  Last update: 2010-11-25 02:35    [W:0.052 / U:0.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site