Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 24 Nov 2010 12:18:33 -0800 | From | Randy Dunlap <> | Subject | Re: [PATCH 00/12] SEP cleanups |
| |
On Wed, 24 Nov 2010 19:23:46 +0000 Alan Cox wrote:
> This is a rework from the bits I sent you a while back Mark (which I suspect > got eaten in the email) and some other cleanup. I've not beaten it up with > CodingStyle yet because most of the debug wants removing before that is done > so it is probably more productive to fix the logic and the inherited choice of > TRUELY_GIANT_DEFINE_NAMES_THAT_CAUSE_MUCH_WRAPPING before we worry about finer > points of style.
TRULY. (or is that Brit. vs. Amer.?)
How about someone addressing these printk format warnings (linux-next)?
drivers/staging/sep/sep_driver.c:115: warning: format '%08x' expects type 'unsigned int', but argument 4 has type 'size_t' drivers/staging/sep/sep_driver.c:149: warning: format '%08x' expects type 'unsigned int', but argument 4 has type 'size_t' drivers/staging/sep/sep_driver.c:170: warning: format '%08x' expects type 'unsigned int', but argument 4 has type 'size_t' drivers/staging/sep/sep_driver.c:212: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'size_t' drivers/staging/sep/sep_driver.c:3397: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'long unsigned int' drivers/staging/sep/sep_driver.c:3399: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'long unsigned int' drivers/staging/sep/sep_driver.c:3405: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'long unsigned int' drivers/staging/sep/sep_driver.c:3407: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'long unsigned int' drivers/staging/sep/sep_driver.c:3411: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'long unsigned int' drivers/staging/sep/sep_driver.c:3413: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'long unsigned int' drivers/staging/sep/sep_driver.c:3415: warning: format '%x' expects type 'unsigned int', but argument 4 has type 'long unsigned int' drivers/staging/sep/sep_driver.c:3738: warning: format '%x' expects type 'unsigned int', but argument 6 has type 'size_t' drivers/staging/sep/sep_driver.c:3866: warning: format '%x' expects type 'unsigned int', but argument 6 has type 'size_t'
--- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
| ![\](/images/icornerr.gif) |