lkml.org 
[lkml]   [2010]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH net-2.6] net, ppp: Report correct error code if unit allocation failed
On Wed, Nov 24, 2010 at 12:49:01PM +0000, Jarek Poplawski wrote:
> On 2010-11-23 22:43, Cyrill Gorcunov wrote:
> > Allocating unit from ird might return several error codes
> > not only -EAGAIN, so it should not be changed and returned
> > precisely. Same time unit release procedure should be invoked
> > only if device is unregistering.
>
> IMHO this unit release fix should be in a separate patch.
>

I thought about it, but still think it should be addressed at
same patch. Though if a separate would be preferred still --
I've no problem in making two patches instead.

> ...
> > @@ -2668,10 +2668,10 @@ static void ppp_shutdown_interface(struc
> > ppp->closing = 1;
> > ppp_unlock(ppp);
> > unregister_netdev(ppp->dev);
> > + unit_put(&pn->units_idr, ppp->file.index);
> > } else
> > ppp_unlock(ppp);
> >
> > - unit_put(&pn->units_idr, ppp->file.index);
> > ppp->file.dead = 1;
> > ppp->owner = NULL;
> > wake_up_interruptible(&ppp->file.rwait);
>
> Btw, it seems these last 3 lines could be moved similarly.

yup, at least ppp->file.dead and ppp->owner for sure, I wanted
make this patch 'unit' orientedc and do not touch anything aside,
it should be a separate change.

>
> Jarek P.
>

Thanks for comments Jarek!

Cyrill


\
 
 \ /
  Last update: 2010-11-24 17:29    [W:0.124 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site