Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH] generic-ipi: add lock context annotations | From | Namhyung Kim <> | Date | Thu, 25 Nov 2010 00:03:41 +0900 |
| |
2010-11-24 (수), 15:33 +0100, Peter Zijlstra: > Aside from complain, do these sparse annotations ever catch a bug? >
Dunno, sorry. I only have very limited experience of kernel development.
> I don't particularly like the __acquire() and __release() tags, but > could possibly live with them when they only need to be in headers, but > the __cond_lock() crap is just revolting.
Yes, it's very ugly. But some people told me it's a better way to describe conditional lock acquisition from complicated functions. It helped sparse recognize normal usage of such functions and suppress warnings but only warn themselves.
-- Regards, Namhyung Kim
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| ![\](/images/icornerr.gif) |