lkml.org 
[lkml]   [2010]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86, dumpstack: Fix unused variable warning.
On Wed, 24 Nov 2010, Frederic Weisbecker wrote:

> On Wed, Nov 24, 2010 at 04:26:01PM +0600, Rakib Mullick wrote:
> > On Wed, Nov 24, 2010 at 3:57 PM, Jesper Juhl <jj@chaosbits.net> wrote:
> > > On Wed, 24 Nov 2010, Rakib Mullick wrote:
> > >
> > >
> > > So, now the bp variable does not exist at all if CONFIG_FRAME_POINTER is
> > > not defined.
> >
> > Yes - right. And its not used outside CONFIG_FRAME_POINTER.
> >
> > > That's going to make this line :
> > >
> > >          show_trace(NULL, NULL, &stack, bp);
> > >
> > Not clear what are you trying to say. Would you please, clear it up a bit?
>
>
> I think Jesper is confused because your patch applies on -tip (tip/master or
> tip/perf/core) where we have zapped the bp argument from show_trace() lately.
>
> But in the mainline, show_trace() still has the bp argument.


Ahh yes, my mistake. I checked the code in mainline.
Sorry about the confusion.


--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.
\
 
 \ /
  Last update: 2010-11-24 15:03    [W:0.025 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site