lkml.org 
[lkml]   [2010]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging/keucr: fix keucr init coding style
On Wed, Nov 24, 2010 at 08:13:29PM +0800, Al Cho wrote:
> - {
> - unsigned int pipe = fDir == FDIR_READ ? us->recv_bulk_pipe : us->send_bulk_pipe;
> - // Bulk
> + if (buf) {
> + unsigned int pipe = fDir == \
> + FDIR_READ ? us->recv_bulk_pipe : us->send_bulk_pipe;
> + /* Bulk */

This isn't a macro so the '\' character isn't needed. Although it still
compiles fine so maybe it isn't a big deal. I would probably do:

unsigned int pipe;

if (fDir == FDIR_READ)
pipe = us->recv_bulk_pipe;
else
pipe = us->send_bulk_pipe;

Otherwise it looks good.

regards,
dan carpenter



\
 
 \ /
  Last update: 2010-11-24 14:03    [W:0.025 / U:1.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site