Messages in this thread | | | Date | Wed, 24 Nov 2010 16:00:03 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging/keucr: fix keucr init coding style |
| |
On Wed, Nov 24, 2010 at 08:13:29PM +0800, Al Cho wrote: > - { > - unsigned int pipe = fDir == FDIR_READ ? us->recv_bulk_pipe : us->send_bulk_pipe; > - // Bulk > + if (buf) { > + unsigned int pipe = fDir == \ > + FDIR_READ ? us->recv_bulk_pipe : us->send_bulk_pipe; > + /* Bulk */
This isn't a macro so the '\' character isn't needed. Although it still compiles fine so maybe it isn't a big deal. I would probably do:
unsigned int pipe;
if (fDir == FDIR_READ) pipe = us->recv_bulk_pipe; else pipe = us->send_bulk_pipe;
Otherwise it looks good.
regards, dan carpenter
| |