| Subject | Re: [PATCH 05/13] writeback: account per-bdi accumulated written pages | From | Peter Zijlstra <> | Date | Wed, 24 Nov 2010 11:26:16 +0100 |
| |
On Wed, 2010-11-17 at 12:27 +0800, Wu Fengguang wrote: > @@ -1292,6 +1292,7 @@ int test_clear_page_writeback(struct pag > PAGECACHE_TAG_WRITEBACK); > if (bdi_cap_account_writeback(bdi)) { > __dec_bdi_stat(bdi, BDI_WRITEBACK); > + __inc_bdi_stat(bdi, BDI_WRITTEN); > __bdi_writeout_inc(bdi); > } > }
Shouldn't that live in __bdi_writeout_inc()? It looks like this forgets about fuse (fuse_writepage_finish() -> bdi_writeout_inc() -> __bdi_writeout_inc()).
|