Messages in this thread | | | From | Francis Moreau <> | Subject | Re: How about limiting refresh ioctl to sampling events ? | Date | Wed, 24 Nov 2010 11:19:08 +0100 |
| |
Peter Zijlstra <a.p.zijlstra@chello.nl> writes:
[...]
>> I'm also wondering if you would accept a second patch which will >> introduce: >> >> static inline bool is_sampling_event(struct perf_event *event) >> { >> return event->attr.sample_period != 0; >> } >> >> That would make the code slighlty easier to read IMHO. >> > > Sure, Francis might want that too, he found another something like this.
Yes there's another issue when counting events are used: they call perf_event_output() when 'period_left' gets 0 where as they should not.
-- Francis
| |