Messages in this thread | | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH][V2] nommu: yield CPU while disposing VM | Date | Tue, 23 Nov 2010 16:16:54 +0900 (JST) |
| |
> Depending on processor speed, page size, and the amount of memory a process > is allowed to amass, cleanup of a large VM may freeze the system for many > seconds. This can result in a watchdog timeout. > > Make sure other tasks receive some service when cleaning up large VMs. > > Signed-off-by: Steven J. Magnani <steve@digidescorp.com> > --- > diff -uprN a/mm/nommu.c b/mm/nommu.c > --- a/mm/nommu.c 2010-11-15 07:53:45.000000000 -0600 > +++ b/mm/nommu.c 2010-11-15 07:57:13.000000000 -0600 > @@ -1668,6 +1668,7 @@ void exit_mmap(struct mm_struct *mm) > mm->mmap = vma->vm_next; > delete_vma_from_mm(vma); > delete_vma(mm, vma); > + cond_resched(); > } > > kleave(""); >
Looks good to me. Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
| |