Messages in this thread | | | Subject | Re: [PATCH 2/2] ext3: Add journal error check into ext3_rename() | From | Namhyung Kim <> | Date | Tue, 23 Nov 2010 12:37:10 +0900 |
| |
2010-11-22 (월), 19:05 +0100, Jan Kara: > Uhuh, why ext3_journal_revoke()? I expect you want to cancel the changes > you possibly did to new_bh. ext3_journal_forget() is for that but even that > doesn't necessarily do what you want because it could cancel also changes > some unrelated operation did to the buffer. So the only way to really undo > the change is to set new_de->inode and new_de->file_type to original > values. Also since we already unlinked the inode from the old directory, > I'm not sure it's even beneficial to undo linking it to the new one. So I'd > just bail out as fast as we can and leave on fsck to handle the mess... > > Honza
Right. I wanted cancel the changes but I wasn't sure what I did. Thanks for the explanation. I'll send v2 soon.
-- Regards, Namhyung Kim
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |