Messages in this thread | | | Subject | Re: [DRAFT PATCH 0/3] perf: Add Intel Nehalem uncore pmu support | From | Peter Zijlstra <> | Date | Tue, 02 Nov 2010 13:29:30 +0100 |
| |
On Tue, 2010-11-02 at 15:27 +0800, Lin Ming wrote: > Any comment is very appreciated.
Right, so I was hoping to use the sysfs bits to expose things, I'll try and get around to looking at your latest effort in that area soonish. I'll try and sit down with gregkh one of these days to talk it over.
I'm not too sure about 1/3's change to x86_perf_event_update(), but its not too aweful, the change to x86_perf_event_set_period() however does look quite gruesome.
It might make sense to simple duplicate that code in the uncore bits,. dunno.
2/3 looks ok, but I think it would be nice if it would be more self contained, that is, not be part of the include mess and possibly have its own NMI_DIE notifier entry.
All in all, Thanks for doing this, its a good start!
| |