lkml.org 
[lkml]   [2010]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] ARM: imx: Add mx53 support to common msl functions.
On Tue, Nov 02, 2010 at 05:17:07PM -0500, Dinh.Nguyen@freescale.com wrote:
> static void query_silicon_parameter(void)
> {
> - void __iomem *rom = ioremap(MX51_IROM_BASE_ADDR, MX51_IROM_SIZE);
> + void __iomem *rom;
> u32 rev;
>
> + if (cpu_is_mx51())
> + rom = ioremap(MX51_IROM_BASE_ADDR, MX51_IROM_SIZE);
> + else if (cpu_is_mx53())
> + rom = ioremap(MX53_IROM_BASE_ADDR, MX53_IROM_SIZE);

else
rom is uninitialized;

I'd also suggest that the above set two variables - base and size, rather
than repeating the ioremap. If you look at the generated code, I suspect
you'll find that the above generates two ioremap calls, whereas using
variables for base and size, and having a common ioremap will reduce the
code size.


\
 
 \ /
  Last update: 2010-11-02 23:23    [W:0.049 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site