Messages in this thread | | | From | Arnaud Patard (Rtp) <> | Subject | Re: [PATCH 2.6.36 1/1] xgifb: change obsolete pci_find_device() with pci_get_device(). | Date | Tue, 02 Nov 2010 16:21:36 +0100 |
| |
Atul Sowani <sowani@gmail.com> writes: Hi,
> Replaced obsolete pci_find_device() calls with pci_get_device() calls. This is > recommended in pci.txt filei in PCI Documentation. > > Signed-off-by: Atul Sowani <sowani@gmail.com> > --- > diff -uprN a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c > --- a/drivers/staging/xgifb/XGI_main_26.c 2010-10-21 02:00:22.000000000 +0530 > +++ b/drivers/staging/xgifb/XGI_main_26.c 2010-11-01 14:25:21.032436943 +0530 > @@ -483,7 +483,7 @@ XGIfb_query_VGA_config_space(struct xgi_ > break; > } > > - pdev = pci_find_device(PCI_VENDOR_ID_SI, nbridge_id, pdev); > + pdev = pci_get_device(PCI_VENDOR_ID_SI, nbridge_id, pdev); > if (pdev) > valid_pdev = 1;
hmm... I guess that a pci_dev_put() call is lacking if it has been found.
Arnaud
| |