lkml.org 
[lkml]   [2010]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: frontier: alphatrack: Fixed coding style issues
On Tue, Nov 02, 2010 at 10:43:44AM +0100, Audun Hoem wrote:
> From: Audun Hoem <audun.hoem@gmail.com>
>
> I cleaned up the coding style.
>
> Signed-off-by: Audun Hoem <audun.hoem@gmail.com>
> ---
> drivers/staging/frontier/alphatrack.c | 9 ++++++---
> 1 files changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/frontier/alphatrack.c b/drivers/staging/frontier/alphatrack.c
> index ef7fbf8..9d439fa 100644
> --- a/drivers/staging/frontier/alphatrack.c
> +++ b/drivers/staging/frontier/alphatrack.c
> @@ -88,8 +88,11 @@ MODULE_SUPPORTED_DEVICE("Frontier Designs Alphatrack Control Surface");
> static int debug = ALPHATRACK_DEBUG;
>
> /* Use our own dbg macro */
> -#define dbg_info(dev, format, arg...) do \
> - { if (debug) dev_info(dev , format , ## arg); } while (0)
> +#define dbg_info(dev, format, arg...) \
> +do {
> + if (debug)
> + dev_info(dev , format , ## arg);
> +} while (0)

Oops, no, this doesn't work, and it breaks the build. Did you test your
patch after you made it?

(hint, you need to add a few more '\' characters...)

Care to redo this and resend it?

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-11-02 14:43    [W:0.024 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site