lkml.org 
[lkml]   [2010]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm: remove call to find_vma in pagewalk for non-hugetlbfs
From
Date
On Fri, 2010-11-19 at 01:39 +0100, David Sterba wrote:
> Commit d33b9f45 introduces a check if a vma is a hugetlbfs one and
> later in 5dc37642 is moved under #ifdef CONFIG_HUGETLB_PAGE but
> a needless find_vma call is left behind and it's result not used
> anywhere else in the function.
>
> The sideefect of caching vma for @addr inside walk->mm is neither
> utilized in walk_page_range() nor in called functions.

Looks good to me.

Acked-by: Matt Mackall <mpm@selenic.com>

--
Mathematics is the supreme nostalgia of our time.




\
 
 \ /
  Last update: 2010-11-19 23:17    [W:1.735 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site