Messages in this thread | | | Subject | Re: [PATCH] mm: remove call to find_vma in pagewalk for non-hugetlbfs | From | Matt Mackall <> | Date | Fri, 19 Nov 2010 14:09:17 -0600 |
| |
On Fri, 2010-11-19 at 01:39 +0100, David Sterba wrote: > Commit d33b9f45 introduces a check if a vma is a hugetlbfs one and > later in 5dc37642 is moved under #ifdef CONFIG_HUGETLB_PAGE but > a needless find_vma call is left behind and it's result not used > anywhere else in the function. > > The sideefect of caching vma for @addr inside walk->mm is neither > utilized in walk_page_range() nor in called functions.
Looks good to me.
Acked-by: Matt Mackall <mpm@selenic.com>
-- Mathematics is the supreme nostalgia of our time.
| |