lkml.org 
[lkml]   [2010]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/9 UPDATED-1] x86: Initialize 32bit logical apicid mapping early during boot
Hey, Ingo.

On 11/18/2010 09:30 AM, Ingo Molnar wrote:
> This patch is still _WAY_ too large.

Really? Alright, I'll split it further.

> Also, these:
>
>> +#ifdef CONFIG_X86_32
>> +#endif
>
>> +#ifdef CONFIG_X86_32
>> +#endif
>
>> +#ifdef CONFIG_X86_32
>> +#endif
>
>> +#ifdef CONFIG_X86_32
>> +#endif
>
> Are rather ugly.

Yeah, what they do is ugly. It gets less uglier after the patchset.
I'll see if some of them can be dropped but I don't think putting them
inside ifdef'd inline functions necessarily improves things. It often
just makes things more difficult to follow.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2010-11-18 09:43    [W:0.452 / U:1.352 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site