Messages in this thread | | | Date | Thu, 18 Nov 2010 14:17:14 -0800 | From | Ron Mercer <> | Subject | Re: [PATCH] qlge: Fix incorrect usage of module parameters and netdev msg level |
| |
On Thu, Nov 18, 2010 at 01:50:02PM -0800, Sonny Rao wrote: > Driver appears to be mistaking the permission field with default value > in the case of debug and qlge_irq_type. > > Driver is also passing debug as a bitmask into netif_msg_init() > which wants a number of bits. Ron Mercer suggests we should > change this to pass in -1 so the defaults get used instead, > which makes the default much less verbose. > > Signed-off-by: Milton Miller <miltonm@bga.com> > Signed-off-by: Sonny Rao <sonnyrao@linux.vnet.ibm.com>
Milton/Sonny, Did you happen to test this to see if the log output was the same?
| |