Messages in this thread | | | Date | Thu, 18 Nov 2010 13:46:19 -0800 | From | Greg KH <> | Subject | Re: [Scst-devel] [PATCH 8/19]: SCST SYSFS interface implementation |
| |
On Fri, Nov 19, 2010 at 12:02:58AM +0300, Vladislav Bolkhovitin wrote: > Since nobody objected, Greg, could you consider to ACK SCST SYSFS > management interface in /sys/kernel/scst_tgt/, please? Please find the > SCST SYSFS ABI documentation file you requested below.
No, sorry, again, you should not be using kobjects, and do not polute the main /sys/kernel/ namespace with this.
Use 'struct device' please, that is what it is there for, and is what the rest of the kernel is using. And use the rest of the driver/bus/device infrastructure as your model will work with it just fine.
Yes, I know you said you didn't think you could use it, and that your code was different than everyone elses, but I still do not believe it, sorry.
good luck,
greg k-h
| |