lkml.org 
[lkml]   [2010]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:perf/core] x86, nmi_watchdog: Remove the old nmi_watchdog
On Thu, Nov 18, 2010 at 11:39:50AM -0800, Yinghai Lu wrote:
> >
> > Please update the kernel-parameters.txt accordingly.
> >
> > and you need to keep unknown_nmi_panic or else as early_param().
> >
> > Also any corresponding part like "nmi_watchdog=off" ?
> >
>
> also you have some other left-over...
>
> Documentation/kernel-parameters.txt: unknown_nmi_panic
> Documentation/kernel-parameters.txt: Set unknown_nmi_panic=1 early on boot.
> Documentation/sysctl/kernel.txt:- unknown_nmi_panic
> Documentation/sysctl/kernel.txt:unknown_nmi_panic:
> arch/x86/include/asm/nmi.h:extern int unknown_nmi_panic;
> arch/x86/kernel/apic/hw_nmi.c:int unknown_nmi_panic;
> kernel/sysctl_binary.c: { CTL_INT, KERN_UNKNOWN_NMI_PANIC, "unknown_nmi_panic" },
>
> may still have left for nmi_watchdog too.

Yes the first part of the patch left in stubs. The second piece should
clean up stuff like nmi_watchdog.

On the other side unknown_nmi_panic is actually going to be added back in
with another patch that re-arranges the default_do_nmi() call that I
posted in another patch series.

Cheers,
Don


\
 
 \ /
  Last update: 2010-11-18 21:05    [W:0.246 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site