lkml.org 
[lkml]   [2010]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/4] net: caif: spi: fix potential NULL dereference
    Date
    alloc_netdev() is not checked here for NULL return value.  dev is
    check instead. It might lead to NULL dereference of ndev.

    Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
    ---
    Compile tested.
    Maybe dev is also must be checked here, but it looks like a trivial typo.

    drivers/net/caif/caif_spi.c | 4 ++--
    1 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/caif/caif_spi.c b/drivers/net/caif/caif_spi.c
    index 8b4cea5..20da199 100644
    --- a/drivers/net/caif/caif_spi.c
    +++ b/drivers/net/caif/caif_spi.c
    @@ -635,8 +635,8 @@ int cfspi_spi_probe(struct platform_device *pdev)

    ndev = alloc_netdev(sizeof(struct cfspi),
    "cfspi%d", cfspi_setup);
    - if (!dev)
    - return -ENODEV;
    + if (!ndev)
    + return -ENOMEM;

    cfspi = netdev_priv(ndev);
    netif_stop_queue(ndev);
    --
    1.7.0.4


    \
     
     \ /
      Last update: 2010-11-18 19:19    [W:7.948 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site