Messages in this thread | | | Date | Thu, 18 Nov 2010 12:52:33 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH 1/4] x86: set cpu masks before calling CPU_STARTING notifiers |
| |
On Thu, 18 Nov 2010, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com> > > When booting up a CPU set the various topology masks before > calling the CPU_STARTING notifier. This way the notifier > can actually use the masks. > > This is needed for a perf change. > > Signed-off-by: Andi Kleen <ak@linux.intel.com> > --- > arch/x86/kernel/smpboot.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c > index 083e99d..9d2980e 100644 > --- a/arch/x86/kernel/smpboot.c > +++ b/arch/x86/kernel/smpboot.c > @@ -281,6 +281,10 @@ static void __cpuinit smp_callin(void) > */ > smp_store_cpu_info(cpuid); > > + /* This must be done before setting cpu_online_mask */
Can we please fix up that comment to match that change ?
> + set_cpu_sibling_map(raw_smp_processor_id()); > + wmb(); > +
Thanks,
tglx
| |