Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH v2 03/20] ARM: LPAE: use u32 instead of unsigned long for 32-bit ptes | Date | Mon, 15 Nov 2010 10:47:36 +0100 |
| |
On Monday 15 November 2010 10:39:30 Catalin Marinas wrote: > > There will be compiler warnings because u32 is unsigned int, and we > > print it as %08lx. Generic code cases pte values to (long long) and > > prints them using %08llx. We should do the same. > > We still need some kind of macro because with LPAE we need %016llx > since the phys address can go to 40-bit and there are some additional > bits in the top word. Unless you'd like to always print 16 characters > even for 32-bit ptes (or if there is some other printk magic I'm not > aware of).
Why not just %010llx? That would just be two extra characters.
Arnd
| |