Messages in this thread | | | Date | Tue, 16 Nov 2010 13:02:40 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [patch] memcg: fix unit mismatch in memcg oom limit calculation |
| |
On Tue, 9 Nov 2010 12:05:21 +0100 Johannes Weiner <hannes@cmpxchg.org> wrote:
> Adding the number of swap pages to the byte limit of a memory control > group makes no sense. Convert the pages to bytes before adding them. > > The only user of this code is the OOM killer, and the way it is used > means that the error results in a higher OOM badness value. Since the > cgroup limit is the same for all tasks in the cgroup, the error should > have no practical impact at the moment. > > But let's not wait for future or changing users to trip over it. > > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
| |