Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 16 Nov 2010 12:37:28 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [patch 1/4] memcg: use native word to represent dirtyable pages |
| |
On Sun, 7 Nov 2010 23:14:36 +0100 Johannes Weiner <hannes@cmpxchg.org> wrote:
> The memory cgroup dirty info calculation currently uses a signed > 64-bit type to represent the amount of dirtyable memory in pages. > > This can instead be changed to an unsigned word, which will allow the > formula to function correctly with up to 160G of LRU pages on a 32-bit > system, assuming 4k pages. That should be plenty even when taking > racy folding of the per-cpu counters into account. > > This fixes a compilation error on 32-bit systems as this code tries to > do 64-bit division. > > Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> > Reported-by: Dave Young <hidave.darkstar@gmail.com>
Thank you.
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
I couldn't read email because of vacation.
| ![\](/images/icornerr.gif) |