Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: autofs4 hang in 2.6.37-rc1 | From | Ian Kent <> | Date | Mon, 15 Nov 2010 21:38:16 +0800 |
| |
On Mon, 2010-11-15 at 15:27 +0200, Avi Kivity wrote: > On 11/15/2010 03:22 PM, Ian Kent wrote: > > > Ian, if you can prove that the lock is not needed, I think we shold > > > just remove it. > > > > I don't think I can prove it but I will have a long look at the code. > > I don't think it is needed and I expect I'll recommend it be removed. > > I've been running with the lock removed for a while with no ill effect. > Of course it doesn't prove anything but at least it's a workaround for me.
Yeah, I tried pretty hard over quite a long time, with the expectation that the BKL would be removed, to try and make the code independent of it. At one point patched the kernel to use the unlocked ioctl entry point during some development testing and found only one fix that was needed, although a lot has changed since then too.
Ian
| ![\](/images/icornerr.gif) |