Messages in this thread | | | Date | Mon, 15 Nov 2010 13:02:11 +0100 | Subject | Re: [2.6.37-rc1-git11] none-BKL-config: stradis.c: e rror: implicit declaration of function ‘lock kernel’/‘ unlock kernel’ | From | Sedat Dilek <> |
| |
On Mon, Nov 15, 2010 at 12:54 PM, Arnd Bergmann <arnd@arndb.de> wrote: > On Sunday 14 November 2010, Sedat Dilek wrote: >> with 2.6.37-rc1-git11 my none-BKL-config breaks (-git9 and -git9457b24 >> were OK) in stradis staging-crap. >> Think the breakage aroses from [1]. >> >> $ cd ~/src/linux-2.6/linux-2.6.37-rc1/debian/build/source_i386_none >> >> $ grep "error:" ../../../../build_linux-2.6_git11.sd.1.log >> /home/sd/src/linux-2.6/linux-2.6.37-rc1/debian/build/source_i386_none/drivers/staging/stradis/stradis.c:1891: >> error: implicit declaration of function ‘lock_kernel’ >> /home/sd/src/linux-2.6/linux-2.6.37-rc1/debian/build/source_i386_none/drivers/staging/stradis/stradis.c:1897: >> error: implicit declaration of function ‘unlock_kernel’ > > The driver is on its way out. I'll do a patch to just mark it "depends > on BKL" to make sure it doesn't get built when BKL is disabled. > > It would be relatively easy to fix the right way, if you are interested. > > Arnd >
I was enjoying the nice sunshine weather on Sunday :-)... here in South-West Germany.
Thus I had not had big time to look into the code... as stradis moved to staging area, it got built this time in a none-BKL-config. I checked a previous kernel and its dot-config and there was no stradis inside, so never built before.
As stradis is marked DEPRECATED and I am not using it (even dunno what it is, sorry for my ignorance), it's not that important.
A "depends on BKL" would be nice for the none-BKL-config folks to not fall into the "pitfall". If you have a patch for stradis, I would add it to my patchset.
Thank you in advance for helping to fix the issue.
- Sedat - -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |