Messages in this thread | | | Date | Sun, 14 Nov 2010 20:21:34 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 3/3] x86: OLPC: speed up device tree creation during boot (v2) |
| |
On 11/14/2010 01:50 AM, Ingo Molnar wrote: > > It's being frowned upon btw, because it's easy to overlook (and for other reasons) - > please dont use statics inside functions - please put them in front of the function > or further up into file scope. >
What? What is wrong with static variables in functions? It really doesn't seem to be a good idea to make them file-scope if they don't need to be.
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |