lkml.org 
[lkml]   [2010]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 02/16 v3] pramfs: super operations
From
hi Marco

> +       retval = 0;
> + out:
> +       if (retval && sbi->virt_addr) {
> +               iounmap(sbi->virt_addr);
> +               release_mem_region(sbi->phys_addr, initsize);
> +               kfree(sbi);
> +       }
> +
> +       return retval;
> +}
> +
I think kfree(sbi) should not be put here. In case of
pram_parse_options failure, sbi should also be freed too. How about
change it to the list below? And change some “goto out” branches to
“goto out_free”.

//    retval = 0;
return 0;
out:
      if (retval && sbi->virt_addr) {
              iounmap(sbi->virt_addr);
              release_mem_region(sbi->phys_addr, initsize);
      }
out_free:
              kfree(sbi);
      return retval;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-11-15 03:29    [W:0.022 / U:1.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site