Messages in this thread | ![/](/images/icornerl.gif) | | From | KOSAKI Motohiro <> | Subject | Re: [PATCH] cleanup kswapd() | Date | Mon, 15 Nov 2010 09:27:32 +0900 (JST) |
| |
> On Sun, 14 Nov 2010, KOSAKI Motohiro wrote: > > > > > Currently, kswapd() function has deeper nest and it slightly harder to > > read. cleanup it. > > > > Cc: Mel Gorman <mel@csn.ul.ie> > > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > > --- > > mm/vmscan.c | 71 +++++++++++++++++++++++++++++++--------------------------- > > 1 files changed, 38 insertions(+), 33 deletions(-) > > > > diff --git a/mm/vmscan.c b/mm/vmscan.c > > index 8cc90d5..82ffe5f 100644 > > --- a/mm/vmscan.c > > +++ b/mm/vmscan.c > > @@ -2364,6 +2364,42 @@ out: > > return sc.nr_reclaimed; > > } > > > > +void kswapd_try_to_sleep(pg_data_t *pgdat, int order) > > Shouldn't this be > > static void kswapd_try_to_sleep(pg_data_t *pgdat, int order) > > ??
Right. thank you. I'll respin.
| ![\](/images/icornerr.gif) |