Messages in this thread | | | Subject | Re: [RFC/PATCH] usb: Add streams support to epautoconf. | From | Felipe Balbi <> | Date | Sun, 14 Nov 2010 22:15:33 +0200 |
| |
Hi,
On Sun, 2010-11-14 at 10:29 -0800, Greg KH wrote: > > + if (USB_ENDPOINT_XFER_BULK == type) { > > Ick, no, don't do comparisons like this. The compiler will let you know > if you acidentally get it wrong with only one '=' character, don't do > things "backward" like this just to work around stupid compilers.
we actually have helpers for this and usb_endpoint_xfer_bulk(desc) would do it.
-- balbi
| |