lkml.org 
[lkml]   [2010]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC/PATCH] usb: Add streams support to epautoconf.
From
Date
Hi,

On Sun, 2010-11-14 at 10:29 -0800, Greg KH wrote:
> > + if (USB_ENDPOINT_XFER_BULK == type) {
>
> Ick, no, don't do comparisons like this. The compiler will let you know
> if you acidentally get it wrong with only one '=' character, don't do
> things "backward" like this just to work around stupid compilers.

we actually have helpers for this and usb_endpoint_xfer_bulk(desc)
would do it.

--
balbi



\
 
 \ /
  Last update: 2010-11-14 21:17    [W:0.104 / U:2.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site