Messages in this thread | | | From | Thomas Renninger <> | Subject | Re: [PATCH 2/3] PERF(kernel): Cleanup power events | Date | Fri, 12 Nov 2010 12:17:10 -0600 |
| |
On Friday 12 November 2010 08:20:47 am Jean Pihet wrote: > Thomas, ... > > + > > + TP_printk("state=%lu cpu_id=%lu", (unsigned long)__entry->state, > > + (unsigned long)__entry->cpu_id) > Using %lu for the state field causes PWR_EVENT_EXIT to appear as > 4294967295 instead of -1. Can the field be of a signed type? This is intended, what exactly is the problem?
... > > + TP_printk("state=%lu", (unsigned long)__entry->state) > Same remark about the unsigned type for the state field. Same. > > > +); > > + > > +#ifdef CONFIG_EVENT_POWER_TRACING_DEPRECATED > > + > > #ifndef _TRACE_POWER_ENUM_ > > #define _TRACE_POWER_ENUM_ > > enum { > > @@ -153,8 +214,32 @@ DEFINE_EVENT(power_domain, power_domain_target, > > > > TP_ARGS(name, state, cpu_id) > > ); > > - > > +#endif /* CONFIG_EVENT_POWER_TRACING_DEPRECATED */ > The clock and power_domain events have been recently introduced and so > must be part of the new API. Can this #endif be moved right after the > definition of power_end? Oops, I pulled again meanwhile and the patches still patched without fuzz, but probably with some offset. I'll look at that and resend this one.
> > #endif /* _TRACE_POWER_H */ > Should this be at the very end of the file? Not sure whether this also came from merge issues, but yes, several #ifdef conditions need to get corrected.
...
> A string is needed here. Without it it is impossible to have the option > unset. > This does the trick: +bool "Deprecated power event trace API, to be removed" Ok, thanks.
I am currently rebuilding on several archs/flavors and hope to be able to re-send this one today or on Tue.
Thanks,
Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |