| Subject | Re: [RFC][PATCH 12/22] sched: add runtime reporting for -deadline tasks | From | Raistlin <> | Date | Fri, 12 Nov 2010 17:15:43 +0100 |
| |
On Thu, 2010-11-11 at 20:37 +0100, Peter Zijlstra wrote: > > -#ifdef CONFIG_SCHEDSTATS > > struct sched_stats_dl { > > +#ifdef CONFIG_SCHEDSTATS > > u64 last_dmiss; > > u64 last_rorun; > > u64 dmiss_max; > > u64 rorun_max; > > -}; > > #endif > > + u64 tot_rtime; > > +}; > > > > I know we agreed to pull this from the sched_param2 structure and delay > exposing this information for a while until the base patches got merged > and came up with a solid use-case, > Sure! :-)
> but reading this patch makes me > wonder why tsk->se.sum_exec_runtime isn't good enough? > Might be, but what you usually want is something reporting you total runtime from when you became a -deadline task, which may not be the case of sum_exec_runtime, is it?
BTW, again, let's postpone this.
Thanks, Dario
-- <<This happens because I choose it to happen!>> (Raistlin Majere) ---------------------------------------------------------------------- Dario Faggioli, ReTiS Lab, Scuola Superiore Sant'Anna, Pisa (Italy)
http://blog.linux.it/raistlin / raistlin@ekiga.net / dario.faggioli@jabber.org [unhandled content-type:application/pgp-signature] |