Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: [PATCH 1/3] Input: xpad - return proper error in error path | Date | Fri, 12 Nov 2010 14:41:08 +0100 |
| |
Am Freitag, 12. November 2010, 03:48:36 schrieb Axel Lin: > In current implementation, xpad_probe return 0 when > usb_alloc_urb failed for xpad->bulk_out and kzalloc failed for xpad->bdata. > > This patch removes the initialization for error variable, > assign the error code at the place the error happens instead.
I am afraid you cannot let stand the order of allocations here anyway, as xpad->irq_in is currently submitted before xpad->bulk_out is allocated. That however is a race, because the callback for irq_in can call xpad360w_process_packet(), which will in turn submit the bulk URB.
I am afraid your patch is pointless unless the logic is also fixed.
Regards Oliver
| |