lkml.org 
[lkml]   [2010]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCHv4 0/4] OMAP: Serial: remove magic and diplicates


> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org
> [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of
> Emeltchenko Andrei
> Sent: Friday, November 12, 2010 6:34 PM
> To: linux-omap@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-arm@lists.arm.linux.org.uk; linux-serial@vger.kernel.org
> Subject: [PATCHv4 0/4] OMAP: Serial: remove magic and diplicates

s/diplicates/duplicates

>
> From: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
>
> Add MDR1 Serial register definition to serial_reg and remove
> duplicated
> code, remove magic MDR1 register numbers from serial drivers.
>
> *v2 add OMAP keyword to MDR1 definition
> *v3 remove magic from serial drivers
> *v4 taking comments from Manjunath and Govindraj: typos, CC
>
> Andrei Emeltchenko (4):
> OMAP: Serial: Define OMAP uart MDR1 register definitions
> OMAP1: Serial: remove magic numbers for MDR1 reg
> OMAP2: Serial: remove magic numbers for MDR1 reg
> OMAP: Serial: remove redefined MDR1 register definitions
>
> arch/arm/mach-omap1/serial.c | 6 ++++--
> arch/arm/mach-omap2/serial.c | 15 +++++++++------
> arch/arm/plat-omap/include/plat/omap-serial.h | 3 ---
> drivers/serial/omap-serial.c | 6 +++---
> include/linux/serial_reg.h | 12 ++++++++++++
> 5 files changed, 28 insertions(+), 14 deletions(-)

Do you think patch series is required for these changes? How about
merging with single patch?

-Manjunath




\
 
 \ /
  Last update: 2010-11-12 14:19    [W:0.037 / U:3.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site