lkml.org 
[lkml]   [2010]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCHv3 2/4] OMAP1: Serial: remobe magic from MDR1 register


> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org
> [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of
> Emeltchenko Andrei
> Sent: Friday, November 12, 2010 2:52 PM
> To: linux-omap@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCHv3 2/4] OMAP1: Serial: remobe magic from MDR1 register

1. s/remobe/remove
2. s/remove magic/remove magic number

After this also, patch title does not match with code. You are not modifying
anything to MDR1 register. You are replacing hardcoded values in serial
API's with macros defined in serial header.

Pls fix patch title accordingly.

-Manjunath

[...]

\
 
 \ /
  Last update: 2010-11-12 13:35    [W:0.048 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site