Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Subject | [PATCH 06/17] staging/vme/tsi148: remove double freeing of the IRQ in .remove | From | Martyn Welch <> | Date | Fri, 12 Nov 2010 11:14:40 +0000 |
| |
From: Emilio G. Cota <cota@braap.org>
tsi148_irq_exit is called twice in .remove, which causes an oops.
Remove the second call, which apart from being redundant cannot possibly work; the CR/CSR space has been already unmapped.
Signed-off-by: Emilio G. Cota <cota@braap.org> Acked-by: Martyn Welch <martyn.welch@ge.com> ---
drivers/staging/vme/bridges/vme_tsi148.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vme/bridges/vme_tsi148.c b/drivers/staging/vme/bridges/vme_tsi148.c index 5c25cd8..2f8f399 100644 --- a/drivers/staging/vme/bridges/vme_tsi148.c +++ b/drivers/staging/vme/bridges/vme_tsi148.c @@ -2611,8 +2611,6 @@ static void tsi148_remove(struct pci_dev *pdev) kfree(master_image); } - tsi148_irq_exit(bridge, pdev); - iounmap(bridge->base); pci_release_regions(pdev);
-- Martyn Welch (Principal Software Engineer) | Registered in England and GE Intelligent Platforms | Wales (3828642) at 100 T +44(0)127322748 | Barbirolli Square, Manchester, E martyn.welch@ge.com | M2 3AB VAT:GB 927559189
| ![\](/images/icornerr.gif) |