Messages in this thread | | | Subject | Re: Tracing Requirements (was: [RFC/Requirements/Design] h/w error reporting) | From | Steven Rostedt <> | Date | Thu, 11 Nov 2010 11:10:16 -0500 |
| |
On Wed, 2010-11-10 at 19:11 -0500, Mathieu Desnoyers wrote:
> > There are also the other common fields: > > > > struct trace_entry { > > unsigned short type; > > > > > > Type is needed by perf. If we have one buffer per event, we could > > retrieve which event we are dealing with. But if buffers are > > multiplexed per cpu, we need this. > > Agreed, although 65536 types ID is probably overkill for the common case. > I prefer to go for approaches with a header that contains a smaller number of > bits, and use an extended header for those rare cases that need it.
Note, ftrace currently has over 600 event types. Unless we compact it down into bits, using two bytes is fine.
-- Steve
| |