lkml.org 
[lkml]   [2010]   [Nov]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] drivers/gpu/drm/vmwgfx: Fix k.alloc switched arguments
On 11/01/2010 12:52 AM, Matt Turner wrote:
> On Sun, Oct 31, 2010 at 6:33 PM, Joe Perches<joe@perches.com> wrote:
>
>> Signed-off-by: Joe Perches<joe@perches.com>
>> ---
>> drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 2 +-
>> drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
>> index a01c47d..29113c9 100644
>> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
>> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c
>> @@ -557,7 +557,7 @@ int vmw_kms_init_legacy_display_system(struct vmw_private *dev_priv)
>> return -EINVAL;
>> }
>>
>> - dev_priv->ldu_priv = kmalloc(GFP_KERNEL, sizeof(*dev_priv->ldu_priv));
>> + dev_priv->ldu_priv = kmalloc(sizeof(*dev_priv->ldu_priv), GFP_KERNEL);
>>
>> if (!dev_priv->ldu_priv)
>> return -ENOMEM;
>> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c b/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c
>> index df2036e..f1a52f9 100644
>> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c
>> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_overlay.c
>> @@ -585,7 +585,7 @@ int vmw_overlay_init(struct vmw_private *dev_priv)
>> return -ENOSYS;
>> }
>>
>> - overlay = kmalloc(GFP_KERNEL, sizeof(*overlay));
>> + overlay = kmalloc(sizeof(*overlay), GFP_KERNEL);
>> if (!overlay)
>> return -ENOMEM;
>>
>> --
>> 1.7.3.1.g432b3.dirty
>>
> Oh! That's a bad one.
>
Indeed.

> Reviewed-by: Matt Turner<mattst88@gmail.com>
>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>

> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>



\
 
 \ /
  Last update: 2010-11-01 23:03    [W:0.171 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site