Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 1 Nov 2010 08:02:01 +0000 | From | Al Viro <> | Subject | Re: [PATCH 2/6] avr32: get rid of useless args in signal.c before other work there |
| |
On Mon, Nov 01, 2010 at 08:58:29AM +0100, Hans-Christian Egtvedt wrote: > On Tue, 2010-09-28 at 03:57 +0100, Al Viro wrote: > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> > > <snipp> > > > @@ -261,11 +261,12 @@ handle_signal(unsigned long sig, struct k_sigaction *ka, siginfo_t *info, > > * doesn't want to handle. Thus you cannot kill init even with a > > * SIGKILL even by mistake. > > */ > > -int do_signal(struct pt_regs *regs, sigset_t *oldset, int syscall) > > +static void do_signal(struct pt_regs *regs, int syscall) > > { > > siginfo_t info; > > int signr; > > struct k_sigaction ka; > > + sigset_t *oldset; > > Should be initialized as it is checked in the else if block further > below.
That else if should be simply else...
| ![\](/images/icornerr.gif) |