Messages in this thread | | | Date | Mon, 1 Nov 2010 14:26:25 -0400 | From | Mathieu Desnoyers <> | Subject | Re: [PATCH] Optimize relay_alloc_page_array() slightly by using vzalloc rather than vmalloc and memset |
| |
* Jesper Juhl (jj@chaosbits.net) wrote: > On Mon, 1 Nov 2010, Mathieu Desnoyers wrote: > > > * Jens Axboe (axboe@kernel.dk) wrote: > > > On 2010-11-01 09:41, Pekka Enberg wrote: > > > > * Jens Axboe (axboe@kernel.dk) wrote: > > > >>> On 2010-10-30 17:47, Mathieu Desnoyers wrote: > > > >>>> BLK_DEV_IO_TRACE seems to still select RELAY. Has it completed its > > > >>>> transition to either Ftrace or Perf ? Depending on Jens, moving blktrace > > > >>>> relay dependency to the Generic Ring Buffer Library might be a good > > > >>>> option to consider. > > > >>> > > > >>> The blktrace user bits is still (by far) the most wide spread way that > > > >>> blktrace is used in the field, and those still rely on relayfs. So no, > > > >>> we can't kill it now. > > > > > > > > On Mon, Nov 1, 2010 at 3:08 PM, Mathieu Desnoyers > > > > <mathieu.desnoyers@polymtl.ca> wrote: > > > >> What I am proposing is that the Generic Ring Buffer Library could > > > >> replace relayfs without changing any of the interfaces blktrace exposes > > > >> to user-space. Indeed, I would not remove relayfs unless there was a > > > >> replacement. > > > > > > > > We don't in general NAK cleanups because of future features or > > > > removals that may or may not happen. > > > > > > Agree, this is parallel to whether or not we can transition blktrace to > > > using the generic ring buffer library or not. If the current patch > > > proposed makes sense, then it should go in regardless of > > > potential/future plans. > > > > Agreed. Thanks, > > > > As I read the discussion over the last day or so, since I last checked my > mail, there are no longer any objections to the patch. Correct?
Yes,
Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> If that's the case, who will merge it? and should I resend it with various > peoples Acked-by: lines? or?
Yep, this might make the maintainer's work easier, I think. As for who will merge it, good question. Andrew ?
Thanks,
Mathieu
-- Mathieu Desnoyers Operating System Efficiency R&D Consultant EfficiOS Inc. http://www.efficios.com
| |