Messages in this thread | | | Date | Mon, 1 Nov 2010 14:34:57 -0400 | From | "J. Bruce Fields" <> | Subject | Re: [PATCH 2/4] locks: fix leaks on setlease errors |
| |
On Mon, Nov 01, 2010 at 01:41:22PM -0400, Christoph Hellwig wrote: > On Mon, Nov 01, 2010 at 01:24:40PM -0400, J. Bruce Fields wrote: > > I also have patches that get rid of fl_release_private, fl_mylease, and > > (almost done) fl_change. > > > > Unless you've a better suggestion I'll probably send them out for review > > and then queue them up with other nfsd changes for 2.6.38. > > Sounds good. I was also wondering if we can get rid of ->setlease > entirely. The file_lock_operations should be enough abstraction to > reject the leases in theory, but I need to look into it a bit more.
Note that cifs has a real lease operation now. No idea how it works or if it's really correct.
--b.
| |