Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 1 Nov 2010 16:06:22 +0900 (JST) | From | KOSAKI Motohiro <> | Subject | Re: [PATCH 1/2] mm, mem-hotplug: recalculate lowmem_reserve when memory hotplug occur |
| |
> On Tue, 26 Oct 2010, KOSAKI Motohiro wrote: > > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index b48dea2..14ee899 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -5002,7 +5002,7 @@ static void __init setup_per_zone_inactive_ratio(void) > > * 8192MB: 11584k > > * 16384MB: 16384k > > */ > > -static int __init init_per_zone_wmark_min(void) > > +int __meminit init_per_zone_wmark_min(void) > > { > > unsigned long lowmem_kbytes; > > > > setup_per_zone_inactive_ratio() should be moved from __init to __meminit, > right?
Right. You are pointing out very old issue. I don't know why old code worked. but we certainly need to fix it. Thank you.
I'll prepare another incremental patch because this is another issue. Thanks.
| ![\](/images/icornerr.gif) |